cmon: Add the remaining dtrace display fields and a default set. - #1971
Merged
Merged
Conversation
leftwo
added this pull request to stack #1969
September 9, 2026 21:58
leftwo
force-pushed
the
alan/cmon-fields
branch
from
September 9, 2026 22:02
b5c2ff4 to
5109c58
Compare
jmpesp
approved these changes
Sep 10, 2026
Added eight more fields from DtraceInfo that had no way to be displayed. Show ds_reconciled and ds_reconcile_needed on their own rather than only as part of the reconcile trio. write_bytes_out, ds_ro_lr_skipped, and the four ds_io_count categories are now split out so a row can show just the ones you care about. Give -o a default set worth looking at, and share it as default_display_fields() so anything else displaying this data starts from the same place. Three columns were wrong. ds_delay printed three per-client values under a single DELAY heading, so everything to its right was shifted; it gets DLY0 DLY1 DLY2 like the other per-client fields. live_repair labelled its third column LRC0 instead of LRC2. next_job_id was seven wide, which a long lived upstairs overflows, so it goes to ten. With ds_delay fixed, every field's header and row are the same width, so the known-broken exemption in that test goes away. The README example is regenerated: it was drawn at the old next_job_id width, and it now shows the default fields rather than an explicit -o.
leftwo
force-pushed
the
alan/cmon-fields
branch
from
September 10, 2026 18:10
5109c58 to
84153b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added eight more fields from DtraceInfo that had no way to be displayed:
ds_reconciled and ds_reconcile_needed on their own rather than only as part of the reconcile trio.
write_bytes_out, ds_ro_lr_skipped, and the four ds_io_count categories split out so a row can show just the ones you care about.
Give -o a default set worth looking at, and share it as default_display_fields() so anything else displaying this data starts
from the same place.
Three columns were wrong. ds_delay printed three per-client values under a single DELAY heading, so everything to its right was shifted. Delay now gets DLY0 DLY1 DLY2 like the other per-client fields.
live_repair labelled its third column LRC0 instead of LRC2.
next_job_id was seven wide, which a long lived upstairs overflows, so it goes to ten.
With ds_delay fixed, every field's header and row are the same width, so the known-broken exemption in that test goes away.