feat: add Slovakia#64
Open
zaggino wants to merge 2 commits intoowenvoke:mainfrom
Open
Conversation
Owner
|
Thanks for opening this PR, I appreciate it! 🙌🏻 That's quite a lot of castles. 😅 I'm going to check some as well tomorrow, but generally the information looks good. |
Owner
|
While checking your file, I noticed that |
Author
|
No worries, I can try iterating on this next week when I have some free time. |
`data/sk.json` failed schema validation: 167 of 210 entries lacked the required `built` field. Researched each via web sources and either populated `built` with a confident date (129 entries) or removed the entry where no credible source could establish one (38 entries).
Author
|
@owenvoke hey, updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a big fan of castles (got actually married on one and did a few roadtrips to visit many of them), so here's some data on the ones from Slovakia.
Honest disclaimer:
I did use AI to collect and translate this data from multiple Slovakian websites (I don't really think any sane person would do it manually), and I've gone through the list manually and read/verified the outputs, checked that the descriptions are accurate and not hallucinations, and also verified some coordinates randomly.
This https://www.hrady-zamky.sk/ and this https://lovechradov.sk/ websites were mostly used to provide the initial data with further enrichment from Wikipedia.