fix: avoid critical logs for argument validation failures (#1193) - #1248
Open
ousamabenyounes wants to merge 1 commit into
Open
fix: avoid critical logs for argument validation failures (#1193)#1248ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
ousamabenyounes
force-pushed
the
fix/issue-1193
branch
from
August 10, 2026 14:39
5a8fc03 to
92722fd
Compare
Treat ArgumentsValidationException like UserError: log its previous cause at ERROR when present, and do not emit a CRITICAL entry for routine validation failures. Other ClientAware exceptions retain their existing CRITICAL logging.
ousamabenyounes
force-pushed
the
fix/issue-1193
branch
from
August 20, 2026 16:22
92722fd to
9bbc592
Compare
Author
|
Updated in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ArgumentsValidationExceptionrepresents invalid client input, butErrorLoggerListenertreated it like an unknown server exception and logged it atCRITICAL.Fix
Treat
ArgumentsValidationExceptionlikeUserError: log its previous cause atERRORwhen one exists, and do not emit aCRITICALentry for a routine validationfailure without a previous cause.
The condition is deliberately limited to
ArgumentsValidationException.Other exceptions implementing
ClientAwareretain their existingCRITICALlogging,because client-safe messages do not necessarily indicate client-caused failures.
Test verification (RED → GREEN)
The two argument-validation cases fail on the unmodified base because they reach the
CRITICALfallback:An additional regression case failed against the earlier generic
ClientAwareimplementation because the expected
CRITICALlog was suppressed:With the final scoped implementation:
The full suite remains iso-baseline: the same five pre-existing
GraphDumpSchemaCommandTestfailures occur onmaster; the final run reportsTests: 715, Assertions: 1722, Failures: 5, Skipped: 8.