✨ Adds support for Actions lock files to detect pinning - #5247
Open
jessehouwing wants to merge 2 commits into
Open
jessehouwing wants to merge 2 commits into
jessehouwing wants to merge 2 commits into
Conversation
jessehouwing
requested review from
justaugustus and
spencerschrock
and removed request for
a team
September 22, 2026 19:05
jessehouwing
force-pushed
the
main
branch
2 times, most recently
from
September 24, 2026 11:31
02d9f49 to
f4957c7
Compare
- Detect actions pinned via github/gh-actions-lock lockfiles (.github/workflows/actions.lock) - Treat \\$/...\ self-repository references as inherently pinned - Fix filepath.Dir/Clean usage on repo-relative (forward-slash) paths in IsWorkflowFile, fileIsInVendorDir, and shell_download_validate - Fix clients/localdir trimPrefix to correctly normalize paths to forward slashes on Windows, fixing --local scans - Add .gitattributes to clients/localdir/testdata to prevent CRLF corruption of binary-compared fixtures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Jesse Houwing <jesse.houwing@gmail.com>
Signed-off-by: Jesse Houwing <jesse.houwing@gmail.com>
Author
|
@JamieMagee you might be interested in this one as well then |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
scorecard only detects pinned actions using
@sha, but ignores the new actions lock files, flooding my security tab with 100's of unpinned actions warnins.What is the new behavior (if this is a feature change)?
Now reads an
actions.lockif present and resolves pins from it.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Generated with copilot, tested against all my own repos on Windows (required additional fixes to make it work on Windows).
Tested on Ubuntu-latest using CI.
Integration tests fail, with a fuzzing error which seems totally unrelated.
Does this PR introduce a user-facing change?
NONE