[FSSDK-12921] Remove DemoObjcApp (Objective-C demo targets)#653
Merged
Conversation
The Objective-C demo app (DemoObjciOS, DemoObjctvOS) is no longer needed. This removes the entire DemoObjcApp directory, its workspace reference, and the corresponding Podfile target blocks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
OCMock was only used in one test method (testTrackWithUserContext in OptimizelyUserContextTests_Objc.m). Replace it with a lightweight SpyEventDispatcher that implements OPTEventDispatcher directly. Also removes all OCMock-related references from project.pbxproj (xcconfigs, lib linkage, shell script build phases). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
coverage: 93.909%. remained the same — muzahidul/cleanup-objc-targets into master |
muzahidul-opti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DemoObjcApp/directory (Objective-C demo app with iOS and tvOS targets)DemoObjcApp.xcodeprojreference from the workspaceDemoObjciOSandDemoObjctvOStarget blocks from the PodfileThe Objective-C demo app is no longer maintained. The Swift demo app
(
DemoSwiftApp) remains as the reference implementation. SDK source code,ObjC bridging extensions, and ObjC test files are all preserved.
Test plan
swift buildpassesEventDispatcherRetryTests.testRetry_AllAttemptsExhaustedunrelated to these changes)DemoObjciOSandDemoObjctvOSschemes are no longer listed in the workspacepod installcompletes successfully with the updated PodfileIssues