refactor: Added ability to inject custom directory for DataStoreFile#612
refactor: Added ability to inject custom directory for DataStoreFile#612asmeili wants to merge 9 commits into
Conversation
|
Hi @muzahidul-opti, could you please review this PR and let me know if any changes are required? |
|
lgtm |
Sure, we will review it. |
|
Hi @muzahidul-opti, are there any updates on this? |
muzahidul-opti
left a comment
There was a problem hiding this comment.
Looks good to me, CI failing could you please fix it?
|
Hi @muzahidul-opti, I fixed the build issue. Could you approve the CI runs to verify? |
|
Hi @raju-opti, could you take a look at this PR and approve the CI runs? |
|
Thanks for the review! I've merged the latest master into the branch, which should take care of the testThreadSafe failure (it's in LruCacheTests, unrelated to this change, looks flaky). The remaining failures don't seem fixable from my side as a fork PR. Could you check again @muzahidul-opti? |
Summary
DataStoreFileto allow for injection of customFileManager.SearchPathDirectoryDefaultEventDispatcherto allow for injection of customFileManager.SearchPathDirectoryforDataStoreType.fileUsers have been raising the issue that they see these technical files inside of their
Filesapp, because the directory forDataStoreFiledefaults to.documentsDirectory, which is visible to users. This change allows us to update the directory to.applicationSupportDirectoryinDefaultEventDispatcherusingDataStoreType.file(directory: .applicationSupportDirectory)and inDefaultDatafileHandlerby overridingopen func createDataStore(sdkKey: String) -> OPTDataStore.Test plan
DataStoreFileIssues