Skip to content

docs(grid): 表格列筛选的属性位置错误#4238

Open
shenjunjian wants to merge 1 commit into
devfrom
shen/fix-grid-col-doc
Open

docs(grid): 表格列筛选的属性位置错误#4238
shenjunjian wants to merge 1 commit into
devfrom
shen/fix-grid-col-doc

Conversation

@shenjunjian

@shenjunjian shenjunjian commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Documentation
    • Updated the grid API docs to include a new optional onResetInputFilter callback for handling input filter resets.
    • Reorganized the interface description so the callback appears in a clearer, more appropriate location.

@shenjunjian shenjunjian added the documentation 对文档的改进或补充 label Jun 29, 2026
@github-actions github-actions Bot added bug Something isn't working and removed documentation 对文档的改进或补充 labels Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5e6f2507-57a0-45a7-88f2-253e3bd7303f

📥 Commits

Reviewing files that changed from the base of the PR and between 46d9cdd and 53d0cb3.

📒 Files selected for processing (1)
  • examples/sites/demos/apis/grid.js

Walkthrough

Repositions the onResetInputFilter optional callback property within the IFilterConfig documented type block in grid.js, moving it earlier in the interface definition. No functional logic changes.

Changes

IFilterConfig Doc Reposition

Layer / File(s) Summary
Reposition onResetInputFilter in IFilterConfig
examples/sites/demos/apis/grid.js
Adds onResetInputFilter?: (ref: any) => void at an earlier position in the IFilterConfig type block and removes its prior occurrence lower in the same block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop, a skip, a property moved,
The interface tidied and slightly improved.
onResetInputFilter found a new home,
No logic changed, just the place it does roam.
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题与变更内容一致,准确概括了表格列筛选属性位置的文档修正。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shen/fix-grid-col-doc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shenjunjian shenjunjian changed the title fix(grid): 表格列筛选的属性位置错误 docs(grid): 表格列筛选的属性位置错误 Jun 29, 2026
@shenjunjian shenjunjian added documentation 对文档的改进或补充 and removed bug Something isn't working labels Jun 29, 2026
@github-actions github-actions Bot removed the documentation 对文档的改进或补充 label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant