Skip to content
This repository was archived by the owner on Jul 13, 2026. It is now read-only.

Use HTTP health check for lightspeed-stack container#128

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:lcore-migrationfrom
umago:lsstack-health
Jul 1, 2026
Merged

Use HTTP health check for lightspeed-stack container#128
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:lcore-migrationfrom
umago:lsstack-health

Conversation

@umago

@umago umago commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Replace the TCP socket readiness/liveness probe with a proper HTTP GET on /readiness and /liveness.

We also need to set the authentication.skip_for_health_probes to true for the kubernetes probes to work.

Summary by CodeRabbit

  • New Features

    • Added health-check settings for the Lightspeed stack container, including liveness, readiness, and startup probe paths and timing values.
    • Authentication handling now includes support for Kubernetes-based config and skips health probes during authentication checks.
  • Bug Fixes

    • Updated container health checks to use HTTPS endpoint checks instead of TCP socket checks, improving probe accuracy and reliability.
    • Improved startup probe behavior for the service container to better handle application startup.

@openshift-ci openshift-ci Bot requested review from Akrog and lpiwowar July 1, 2026 08:42
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8af61ec5-e283-4125-bf1d-c1b580765913

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved label Jul 1, 2026
lpiwowar
lpiwowar previously approved these changes Jul 1, 2026

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!:) 👍

Comment thread internal/controller/constants.go
Replace the TCP socket readiness/liveness probe with a proper HTTP GET on
/readiness and /liveness.

We also need to set the authentication.skip_for_health_probes to true
for the kubernetes probes to work.

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@lpiwowar

lpiwowar commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 1, 2026
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit a8a71f8 into openstack-lightspeed:lcore-migration Jul 1, 2026
8 checks passed
@umago umago deleted the lsstack-health branch July 1, 2026 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants