Skip to content

Lcore dev improvements#125

Closed
Akrog wants to merge 3 commits into
openstack-lightspeed:lcore-migrationfrom
Akrog:lcore-dev-improvements
Closed

Lcore dev improvements#125
Akrog wants to merge 3 commits into
openstack-lightspeed:lcore-migrationfrom
Akrog:lcore-dev-improvements

Conversation

@Akrog

@Akrog Akrog commented Jun 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Just some small improvements for developers:

  • ocp-deploy and ocp-deploy-cleanup targets
  • GOMAXPROCS support to limit parallel processes during golang compilation
  • Add kuttl test artifacts to .gitignore

Summary by CodeRabbit

  • New Features

    • Improved OpenShift deployment flow with a new cleanup step for registry/catalog resources.
    • Added stronger teardown behavior to remove deployed application resources more completely.

  • Bug Fixes

    • Build and container image creation now propagate CPU settings more consistently, helping ensure more reliable builds in different environments.

  • Chores

    • Updated ignored test artifacts so temporary KUTTL files are no longer tracked.

@Akrog
Add kuttl test artifacts to .gitignore
9f301ec 
Simply ignore the `kubeconfig` and
`kuttl-report-openstack-lightspeed.xml` files that are generated during
a kuttl test run (eg: `make kuttl-test-ocp`).
@openshift-ci openshift-ci Bot requested review from lpiwowar and umago June 24, 2026 15:48
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f091779e-6515-4936-a590-d5e7822adad4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Akrog Akrog mentioned this pull request Jun 25, 2026
Open
lpiwowar
lpiwowar reviewed Jun 29, 2026
View reviewed changes

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is helpful!

Only one super small nit. I'll give a time for the fix. If it does not happen I'm ok with /lgtm by whomever comes after me.

Comment thread Makefile Outdated
ocp-deploy: IMG = $(OCP_INTERNAL_REGISTRY)/$(OCP_REGISTRY_NAMESPACE)/operator:latest
ocp-deploy: BUNDLE_IMG = $(OCP_INTERNAL_REGISTRY)/openshift-marketplace/operator-bundle:$(TAG)
ocp-deploy: CATALOG_IMG = $(OCP_INTERNAL_REGISTRY)/openshift-marketplace/operator-catalog:$(TAG)
ocp-deploy: docker-build bundle bundle-build ocp-catalog-build ocp-registry-push openstack-lightspeed-deploy

@lpiwowar lpiwowar Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (non-blocking):

Suggested change
ocp-deploy: docker-build bundle bundle-build ocp-catalog-build ocp-registry-push openstack-lightspeed-deploy
ocp-deploy: docker-build bundle bundle-build ocp-catalog-build ocp-registry-push openstack-lightspeed-deploy ## Build, push, and deploy the operator on an OCP cluster.

umago
umago reviewed Jun 29, 2026
View reviewed changes

@umago umago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Lukas left a small nit inline. We can approve after that update

Akrog added 2 commits July 6, 2026 14:08
@Akrog
Add ocp-deploy and ocp-deploy-cleanup targets
088608c 
Similar to `kuttl-test-ocp` that deploys and runs kuttl we now add a
couple of convenient make targets to help development:

- `ocp-deploy`
- `ocp-deploy-cleanup`
@Akrog
Add GOMAXPROCS support when building
000a6ff 
Right now when we build the container (make docker-build) or the
controller (make build) the go compiler will try to use all the CPUs on
the machine.

This can become problematic in some systems that may suffer starvation
(eg: audio problems), so we add support for the `GOMAXPROCS` env var to
be passed to those 2 make targets.
@Akrog Akrog force-pushed the lcore-dev-improvements branch from 7396ab6 to 000a6ff Compare July 6, 2026 12:08
@Akrog Akrog mentioned this pull request Jul 6, 2026
Merged
@Akrog

Akrog commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Closed after proposing the PR to new repository: openstack-k8s-operators/lightspeed-operator#10

@Akrog Akrog closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umago umago umago left review comments
@lpiwowar lpiwowar lpiwowar left review comments

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Akrog @umago @lpiwowar