Skip to content

Add support for gemini#114

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:lcore-migrationfrom
dprince:lcore-migration-gemini
Jun 17, 2026
Merged

Add support for gemini#114
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:lcore-migrationfrom
dprince:lcore-migration-gemini

Conversation

@dprince

@dprince dprince commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

NOTE: gemini should work as is, but in order to enable gemini tool calling this fix is also needed ogx-ai/ogx#5082

Works like this:

apiVersion: lightspeed.openstack.org/v1beta1
kind: OpenStackLightspeed
metadata:
name: gemini
spec:
llmEndpoint: https://generativelanguage.googleapis.com/v1beta/openai
llmEndpointType: gemini
llmCredentials: gemini-secret
modelName: models/gemini-2.5-flash
lcore:
models:
- metadata: {}
model_id: models/gemini-2.5-flash
provider_id: gemini
provider_model_id: models/gemini-2.5-flash

@openshift-ci openshift-ci Bot requested review from Akrog and umago June 12, 2026 17:08
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 04a7d195-3dfe-4fb1-ac0f-35737bead299

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

Hi @dprince. Thanks for your PR.

I'm waiting for a openstack-lightspeed member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprince dprince force-pushed the lcore-migration-gemini branch from 892d46f to 5dc7ee1 Compare June 12, 2026 17:18
@lpiwowar

Copy link
Copy Markdown
Contributor

/ok-to-test

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.


Generating unit tests... This may take up to 20 minutes.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

❌ Failed to create PR with unit tests: AGENT_CHAT: Failed to open pull request

@umago

umago commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Code wise it looks good to me. Needs to fix the CI before we can approve it

@dprince dprince force-pushed the lcore-migration-gemini branch from 5dc7ee1 to 1149335 Compare June 15, 2026 13:27
umago
umago previously approved these changes Jun 15, 2026
@umago umago requested a review from lpiwowar June 15, 2026 14:17

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change in ./bundle needed 🙈

--- a/bundle/manifests/lightspeed.openstack.org_openstacklightspeeds.yaml
+++ b/bundle/manifests/lightspeed.openstack.org_openstacklightspeeds.yaml
@@ -109,6 +109,7 @@ spec:
                 - rhoai_vllm
                 - rhelai_vllm
                 - fake_provider
+                - gemini
                 type: string

@umago umago dismissed their stale review June 16, 2026 08:05

CI failure

@openshift-ci openshift-ci Bot removed the approved label Jun 16, 2026
NOTE: gemini should work as is, but in order to enable gemini tool
calling this fix is also needed ogx-ai/ogx#5082
@dprince dprince force-pushed the lcore-migration-gemini branch from 1149335 to 77c43b2 Compare June 16, 2026 17:30
@lpiwowar

Copy link
Copy Markdown
Contributor

/retest

@lpiwowar lpiwowar self-requested a review June 17, 2026 08:21

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for the PR!:)

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 48b5142 into openstack-lightspeed:lcore-migration Jun 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants