Add support for gemini#114
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @dprince. Thanks for your PR. I'm waiting for a openstack-lightspeed member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
892d46f to
5dc7ee1
Compare
|
/ok-to-test |
|
Note Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
|
❌ Failed to create PR with unit tests: AGENT_CHAT: Failed to open pull request |
|
Code wise it looks good to me. Needs to fix the CI before we can approve it |
5dc7ee1 to
1149335
Compare
lpiwowar
left a comment
There was a problem hiding this comment.
Change in ./bundle needed 🙈
--- a/bundle/manifests/lightspeed.openstack.org_openstacklightspeeds.yaml
+++ b/bundle/manifests/lightspeed.openstack.org_openstacklightspeeds.yaml
@@ -109,6 +109,7 @@ spec:
- rhoai_vllm
- rhelai_vllm
- fake_provider
+ - gemini
type: string
NOTE: gemini should work as is, but in order to enable gemini tool calling this fix is also needed ogx-ai/ogx#5082
1149335 to
77c43b2
Compare
|
/retest |
lpiwowar
left a comment
There was a problem hiding this comment.
/lgtm
Thank you for the PR!:)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
48b5142
into
openstack-lightspeed:lcore-migration
NOTE: gemini should work as is, but in order to enable gemini tool calling this fix is also needed ogx-ai/ogx#5082
Works like this:
apiVersion: lightspeed.openstack.org/v1beta1
kind: OpenStackLightspeed
metadata:
name: gemini
spec:
llmEndpoint: https://generativelanguage.googleapis.com/v1beta/openai
llmEndpointType: gemini
llmCredentials: gemini-secret
modelName: models/gemini-2.5-flash
lcore:
models:
- metadata: {}
model_id: models/gemini-2.5-flash
provider_id: gemini
provider_model_id: models/gemini-2.5-flash