Skip to content

nova_verify, pre_launch_ironic: fix ironic post-adoption provisioning#1412

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:fix/nova-verify-ironic-post-adoption-guard
Jul 3, 2026
Merged

nova_verify, pre_launch_ironic: fix ironic post-adoption provisioning#1412
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:fix/nova-verify-ironic-post-adoption-guard

Conversation

@rebtoor

@rebtoor rebtoor commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Problem

The post-adoption ironic instance provisioning task in nova_verify.yaml
can fail with quota exceeded (HTTP 403) when the adopted environment
already uses all available instances (e.g. uni04delta-ipv6 with 10 VMs
from the source cloud at the default quota of 10).

Fix

  • Bump the instance quota by one before creating the post-adoption test
    instance so it works regardless of source cloud instance count.
  • Add ironic_post_adoption_create_instance variable (default true) to
    allow scenarios to skip the post-adoption provisioning step entirely.

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 5, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/d6af17d5837c4eaf8380de76124501d1

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph POST_FAILURE in 3h 08m 54s
❌ adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 14m 40s

@rebtoor

rebtoor commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 6, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/02d9f9c9912b4ebca736fd0750a11aca

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph POST_FAILURE in 3h 09m 56s
❌ adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 12m 55s

@rebtoor rebtoor force-pushed the fix/nova-verify-ironic-post-adoption-guard branch from ce9611a to 38fa07e Compare June 8, 2026 06:40
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 8, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/92341c393e3c47b1bfdc2afba9501759

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph RETRY_LIMIT in 30m 11s
❌ adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 17m 30s

@rebtoor rebtoor force-pushed the fix/nova-verify-ironic-post-adoption-guard branch from 38fa07e to 0f27d22 Compare June 9, 2026 06:37
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/e44d59b08cfe4a45934f9b66e7c79c76

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph POST_FAILURE in 3h 08m 06s
❌ adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 09m 07s

@rebtoor rebtoor force-pushed the fix/nova-verify-ironic-post-adoption-guard branch from 0f27d22 to 1120d02 Compare June 10, 2026 06:42
@rebtoor rebtoor changed the title nova_verify: add ironic_post_adoption_create_instance guard nova_verify, pre_launch_ironic: fix ironic post-adoption provisioning Jun 10, 2026
@rebtoor rebtoor force-pushed the fix/nova-verify-ironic-post-adoption-guard branch from 1120d02 to 5ba055f Compare June 10, 2026 06:53
jistr
jistr approved these changes Jun 17, 2026
View reviewed changes

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 17, 2026
@jistr

jistr commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Not a blocker but i do wonder if it would be better to just have the quota set correctly from the start :)

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Jul 3, 2026
@rebtoor rebtoor removed the Stale label Jul 3, 2026
@rebtoor rebtoor force-pushed the fix/nova-verify-ironic-post-adoption-guard branch from 5ba055f to 90dcd9b Compare July 3, 2026 07:50
@openshift-ci openshift-ci Bot removed the lgtm label Jul 3, 2026
@rebtoor rebtoor force-pushed the fix/nova-verify-ironic-post-adoption-guard branch from 90dcd9b to 6f89612 Compare July 3, 2026 07:53
@rebtoor @cursoragent
nova_verify, pre_launch_ironic: fix ironic post-adoption provisioning
2fe2c57 
The post-adoption ironic instance provisioning task in nova_verify.yaml
can fail with quota exceeded (HTTP 403) when the adopted environment
already uses all available instances (e.g. uni04delta-ipv6 with 10 VMs
from the source cloud at the default quota of 10).

Set the instance quota correctly from the start in pre_launch_ironic.bash
by reading the current quota and adding headroom for the pre-adoption
and post-adoption test instances. The quota carries over through the
Nova database migration during adoption, so the post-adoption
provisioning step no longer hits the limit.

Also add ironic_post_adoption_create_instance variable (default true)
to allow scenarios to skip the post-adoption provisioning step entirely.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebtoor rebtoor force-pushed the fix/nova-verify-ironic-post-adoption-guard branch from 6f89612 to 2fe2c57 Compare July 3, 2026 07:54
jistr
jistr approved these changes Jul 3, 2026
View reviewed changes

@jistr jistr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 3, 2026
@rebtoor rebtoor requested review from ciecierski and holser July 3, 2026 13:48
holser
holser approved these changes Jul 3, 2026
View reviewed changes

@holser holser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rebtoor

rebtoor commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/lgtm

care to add an /approve as well? :D

@holser

holser commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: holser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jul 3, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 5d24308 into openstack-k8s-operators:main Jul 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jistr jistr jistr approved these changes
@holser holser holser approved these changes
@ciecierski ciecierski Awaiting requested review from ciecierski

Assignees

@jistr jistr

@holser holser

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rebtoor @jistr @holser