Repository navigation
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
f943979 to
6ab7158
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 21s Warning: |
0b00427 to
5997ebc
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
5997ebc to
f764522
Compare
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 53m 14s Warning: |
| {% if neighbor is mapping %} | ||
| - set protocols bgp group {{ group.name }} neighbor {{ neighbor.address }} | ||
| {% if neighbor.authentication_key is defined %} | ||
| - set protocols bgp group {{ group.name }} neighbor {{ neighbor.address }} authentication-key "{{ neighbor.authentication_key }}" |
There was a problem hiding this comment.
(blocking) concern: Might be necessary adding here no_log: true? So we don't expose this key.
| - {{ line }} | ||
| {% endfor %} | ||
| junipernetworks.junos.junos_config: | ||
| lines: "{{ bgp_config | from_yaml }}" |
There was a problem hiding this comment.
(non-blocking) question: should we skip if bgp_config is empty?
NFV EVPN labs use a Juniper switch as the BGP-EVPN route-reflector for the EDPM computes (and the traffic generator), but switch_config could only handle interfaces, VLANs, LACP, IGMP snooping and DCB. The route-reflector had to be configured by hand, so a fresh environment came up with its EVPN control plane silently down (computes stuck in Active towards the RR). Add an optional `bgp` key to the switch vars that renders `set routing-options ...` and `set protocols bgp group ...` lines (local AS, router-id, groups with type/local-address/peer-as/cluster/families/ neighbors) plus `extra_lines` for any raw Junos `set` statement not covered by the schema (e.g. the irb interface carrying the RR address). A neighbor can be given as a mapping with a per-neighbor TCP-MD5 `authentication_key`, so peers that sign their sessions (e.g. EDPM FRR with a neighbor password) can share a group with peers that do not. Only `set` lines are pushed, so groups owned by other environments on a shared switch are left untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
f764522 to
d35dae9
Compare
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 27m 13s Warning: |
NFV EVPN labs use a Juniper switch as the BGP-EVPN route-reflector for the EDPM computes (and the traffic generator), but switch_config could only handle interfaces, VLANs, LACP, IGMP snooping and DCB. The route-reflector had to be configured by hand, so a fresh environment came up with its EVPN control plane silently down (computes stuck in Active towards the RR).
Add an optional
bgpkey to the switch vars that rendersset routing-options ...andset protocols bgp group ...lines (local AS, router-id, groups with type/local-address/peer-as/cluster/families/ neighbors) plusextra_linesfor any raw Junossetstatement not covered by the schema (e.g. the irb interface carrying the RR address). A neighbor can be given as a mapping with a per-neighbor TCP-MD5authentication_key, so peers that sign their sessions (e.g. EDPM FRR with a neighbor password) can share a group with peers that do not. Onlysetlines are pushed, so groups owned by other environments on a shared switch are left untouched.🤖 Generated with Claude Code