Skip to content

Disable inspection while IPA is not updated - #4270

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
mumesan:disable-inspection-if-agent
Oct 21, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
mumesan:disable-inspection-if-agent

Conversation

@mumesan

@mumesan mumesan commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

When inspect-interface=agent is configured for ironic-operator, IPA handles introspection via the continue_inspection endpoint. This endpoint is not compatible right now and results in a 400 error and inspection failure. This PR adds a flag to allow skipping the inspection step in jobs where this is known to fail.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@mumesan
mumesan force-pushed the disable-inspection-if-agent branch 2 times, most recently from d95bf88 to b60dc33 Compare October 19, 2026 19:08

@hjensas hjensas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to change this to have a variable that can be set by jobs to toggle inspection on off. See inline comment.

@centosinfra-prod-github-app

Copy link
Copy Markdown

When inspect-interface=agent is configured for ironic-operator, IPA handles
introspection via the continue_inspection endpoint. This endpoint is not
compatible right now and results in a 400 error and inspection failure. This PR
adds a flag to allow skipping the inspection step in jobs where this is known
to fail.

Signed-off-by: Mithun Krishnan Umesan <mumesan@redhat.com>
@mumesan
mumesan force-pushed the disable-inspection-if-agent branch from b60dc33 to 4cdfb7e Compare October 20, 2026 10:53

@abhibongale abhibongale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/ff82836b09d14ca1a667eff795e158dd

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 31m 13s
❌ cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 06m 16s (non-voting)
✔️ periodic-podified-edpm-baremetal-minor-update-bootc-master-ocp-crc SUCCESS in 1h 51m 44s (non-voting)
❌ openstack-k8s-operators-content-provider-bootc FAILURE in 40m 40s
⚠️ cifmw-crc-podified-edpm-baremetal-bootc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider-bootc (non-voting)
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 21s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 54s

@karelyatin karelyatin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karelyatin

Copy link
Copy Markdown
Contributor

recheck unrelated failure

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/64851191a2b943ac9fcd0aa0e12129d7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 13s
❌ cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 04m 39s (non-voting)
✔️ periodic-podified-edpm-baremetal-minor-update-bootc-master-ocp-crc SUCCESS in 1h 53m 58s (non-voting)
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 2h 26m 57s
❌ cifmw-crc-podified-edpm-baremetal-bootc FAILURE in 1h 49m 18s (non-voting)
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 36s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 00s

@openshift-ci

openshift-ci Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 732a981 into openstack-k8s-operators:main Oct 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants