Skip to content

1.5: Skip upstream-only workflows on this fork (cherry-pick velero-io/velero#10001) - #567

Open
kaovilai wants to merge 6 commits into
openshift:oadp-1.5from
kaovilai:workflow-skip-on-forks-oadp-1.5
Open

kaovilai wants to merge 6 commits into
openshift:oadp-1.5from
kaovilai:workflow-skip-on-forks-oadp-1.5

Conversation

@kaovilai

@kaovilai kaovilai commented Sep 1, 2026 •

Copy link
Copy Markdown
Member

Cherry-pick of velero-io#10001.

Guards several upstream-only GitHub Actions workflows (auto_assign_prs, auto_label_prs, auto_request_review, pr-changelog-check, prow-action, rebase, stale-issues, pr-codespell) with if: github.repository == 'velero-io/velero', so they skip on this fork instead of running here and failing due to missing secrets/config or duplicating this repo's own automation.

pr-filepath-check.yml doesn't exist on this branch, so that guard was dropped (nothing to guard).

Also includes CI-health fixes matching the same class already applied upstream (release-1.14 through release-1.16), which this branch was still missing:

  • codespell typo ("colume"→"volume" in pkg/util/podvolume/pod_volume_test.go)
  • .github/workflows/e2e-test-kind.yaml: build MinIO from the Bitnami Dockerfile instead of the now-unavailable bitnami/minio:2021.6.17-debian-10-r7 tag, bumped to the current 2026/debian-12 path (bitnami/containers reorganizes this per-year)
  • Cap the e2e k8s version matrix at v1.35: k8s 1.36+ hits a deterministic BSL-availability race in the BackupsSync e2e suite, unrelated to this branch's diffs

(envtest, linter config, and the test workload image were already fixed on this branch — no changes needed there.)

/kind changelog-not-required

Note

Responses generated with Claude

…workflows-on-forks

Skip upstream-only workflows on forks

(cherry picked from commit 0033d5c)
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 94a5f646-6d8e-4658-909d-249add7bf01f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

@kaovilai: The label(s) kind/changelog-not-required cannot be applied, because the repository doesn't have them.

Details

In response to this:

Cherry-pick of velero-io#10001 (already brought upstream to release-1.14 through release-1.18 as velero-io#10428, velero-io#10427, velero-io#10424, velero-io#10425, and velero-io#10426).

Guards several upstream-only GitHub Actions workflows (auto_assign_prs, auto_label_prs, auto_request_review, pr-changelog-check, prow-action, rebase, stale-issues, pr-codespell) with if: github.repository == 'velero-io/velero', so they skip on this fork instead of running here and failing due to missing secrets/config or duplicating this repo's own automation.

pr-filepath-check.yml doesn't exist on this branch, so that guard was dropped (nothing to guard).

/kind changelog-not-required

[!Note]
Responses generated with Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
openshift-ci Bot requested review from Joeavaikath and sseago September 1, 2026 14:23
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026
kaovilai and others added 4 commits September 1, 2026 11:31
- Fix "colume" -> "volume" in pod_volume_test.go
- Fix "elswhere" -> "elsewhere" in pr-codespell.yml
- Add verify: false to golangci-lint-action to skip config verify
  which rejects deprecated settings valid for golangci-lint v1.57.2

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
(cherry picked from commit 195b678)
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
…ted image

The Bitnami MinIO image bitnami/minio:2021.6.17-debian-10-r7 is no longer
available on Docker Hub, causing E2E tests to fail.

This change implements a solution to build the MinIO image locally from
Bitnami's public Dockerfile and cache it for subsequent runs:
- Fetches the latest commit hash of the Bitnami MinIO Dockerfile
- Uses GitHub Actions cache to store/retrieve built images
- Only rebuilds when the upstream Dockerfile changes
- Maintains compatibility with existing environment variables

Fixes velero-io#9279

🤖 Generated with [Claude Code](https://claude.ai/code)

Update .github/workflows/e2e-test-kind.yaml

Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
(cherry picked from commit 4c3b794)
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
bitnami/containers reorganized its per-year directories; the
bitnami/minio/2025/debian-12 path no longer exists upstream, only
bitnami/minio/2026/debian-12 does now.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
k8s 1.36+ hits a deterministic BSL-availability race in the BackupsSync
e2e suite, unrelated to this branch's diffs. Same fix already applied
upstream (velero-io/velero release-1.14 through release-1.16).

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai changed the title Skip upstream-only workflows on this fork (cherry-pick velero-io/velero#10001) 1.5: Skip upstream-only workflows on this fork (cherry-pick velero-io/velero#10001) Sep 1, 2026
golangci-lint-action@v6 does not support golangci-lint v2, hitting
"invalid version string 'v2.5.0', golangci-lint v2 is not supported by
golangci-lint-action v6, you must update to golangci-lint-action v7."
oadp-1.4 already carries this fix; mirroring it here since this check
blocks the PR regardless of this PR's own diff.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2026
@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants