feat(gateways): show gateway creator in the list view - #181
Open
maknop wants to merge 5 commits into
Open
Conversation
Adds a "Created by" column to the gateway list table. The API server resolves the owner username by querying the RBAC role bindings table for the user holding the gateway:owner role, then surfaces it as a read-only created_by field on the Gateway response. The lookup runs only on the list endpoint to avoid unnecessary extra queries on create, patch, and get. The UI renders the username with a "Not available" fallback when no owner binding exists. 💘 Generated with Crush Assisted-by: Crush:claude-sonnet-4-6
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
maknop
marked this pull request as draft
August 21, 2026 18:59
- Format Go files (presenter.go, dao.go) to satisfy gofmt - Use roles.RoleGatewayOwner constant instead of hardcoded string in DAO - Move 'owner' message key to correct alphabetical position in messages.ts - Restore createdBy on GatewayConnection (required by the table render) - Regenerate TypeScript SDK to include the new created_by field - Rebuild SDK dist so web-console picks up the updated types - Extract active_sandbox_count and console_address via typed helpers in the web-console adapter to satisfy no-unsafe-assignment - Add created_by to the web-console test fixture to satisfy the non-optional type emitted by the SDK generator 💘 Generated with Crush Assisted-by: Crush:claude-sonnet-4-6
The new 'Created by' column caused the e2e locator for the 'Created' column header to match two elements. Adding exact: true scopes the match to the precise label. 💘 Generated with Crush Assisted-by: Crush:claude-sonnet-4-6
maknop
marked this pull request as ready for review
August 21, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Created by" column to the gateway list table. The API server resolves the owner username by querying the RBAC role bindings table for the user holding the gateway:owner role, then surfaces it as a read-only created_by field on the Gateway response. The lookup runs only on the list endpoint to avoid unnecessary extra queries on create, patch, and get. The UI renders the username with a "Not available" fallback when no owner binding exists.
Assisted-by: Crush:claude-sonnet-4-6