Skip to content

964: fix sim sum plots - #965

Merged
danielinteractive merged 21 commits into
mainfrom
964_fix_sim_sum_plots
Sep 9, 2026
Merged

danielinteractive merged 21 commits into
mainfrom
964_fix_sim_sum_plots

Conversation

@danielinteractive

Copy link
Copy Markdown
Collaborator

closes #964

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files     59 suites   2m 13s ⏱️
1 794 tests 1 593 ✅ 201 💤 0 ❌
5 693 runs  5 421 ✅ 272 💤 0 ❌

Results for commit 7c6794b.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Data-methods 💔 $4.69$ $+1.00$ $0$ $0$ $0$ $0$
Design-methods 💔 $17.43$ $+5.72$ $0$ $0$ $0$ $0$
HierarchicalModel 💔 $5.57$ $+1.25$ $0$ $0$ $0$ $0$
Model-class 💔 $4.83$ $+1.54$ $0$ $0$ $0$ $0$
Rules-methods 💔 $15.68$ $+6.49$ $+29$ $+2$ $0$ $0$
Samples-methods 💔 $7.32$ $+3.48$ $0$ $0$ $0$ $0$
Simulations-methods 💔 $9.78$ $+4.78$ $+46$ $+4$ $0$ $0$
sas-results-part-2 💔 $3.80$ $+1.55$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Rules-methods 👶 $+0.59$ nextBest_NextBestNCRM_optionally_plots_probabilities_on_a_log_dose_scale
Rules-methods 👶 $+0.58$ nextBest_NextBestNCRM_supports_lollipop_and_legacy_bar_plots
Rules-methods 👶 $+0.51$ nextBest_NextBestNCRM_uses_dose_grid_ticks_by_default
Simulations-methods 👶 $+0.04$ doses_tried_optionally_uses_regular_axis_ticks
Simulations-methods 👶 $+0.11$ doses_tried_uses_equal_width_bars_and_automatically_logs_clashes
Simulations-methods 👶 $+0.03$ doses_tried_uses_lollipops_by_default
Simulations-methods 👶 $+0.05$ plot_GeneralSimulations_supports_log_dose_axes
Simulations-methods 👶 $+0.17$ plot_PseudoSimulationsSummary_shows_representative_DLE_proportions
Simulations-methods 👶 $+0.15$ plot_SimulationsSummary_shows_representative_DLT_proportions
Simulations-methods 👶 $+0.20$ plot_SimulationsSummary_shows_representative_MTD_selections
Simulations-methods 👶 $+0.45$ plot_SimulationsSummary_shows_the_corrected_summary_dashboard
Simulations-methods 👶 $+0.02$ simulation_dose_plots_reject_nonpositive_doses_on_log_axes
Simulations-methods 👶 $+0.10$ simulation_trajectory_uses_nested_blue_ranges_and_a_median_line
helpers-simulations 👶 $+0.02$ h_barplot_percentages_rotates_discrete_x_axis_labels
helpers-simulations 👶 $+0.07$ h_barplot_percentages_supports_fixed_width_discrete_bars
helpers-simulations 👶 $+0.07$ h_histogram_percentages_creates_a_percentage_histogram
helpers-simulations 👶 $+0.02$ h_histogram_percentages_fails_gracefully_with_bad_input
helpers_rules 👶 $+0.17$ h_next_best_probability_plot_supports_lollipop_and_legacy_bars

Results for commit 1764e6d

♻️ This comment has been updated with latest results.

@danielinteractive

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-31T12:38:36.253359Z ca73fbc Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca73fbc668

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread R/helpers_simulations.R
Comment thread R/helpers_simulations.R
@danielinteractive
danielinteractive merged commit 683da3d into main Sep 9, 2026
20 of 21 checks passed
@danielinteractive
danielinteractive deleted the 964_fix_sim_sum_plots branch September 9, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve simulation summary plots

1 participant