Fix: resolve issue #122 (Facility role duplicates on migration re-run) - #123
Open
yaegerbomb42 wants to merge 1 commit into
Open
Fix: resolve issue #122 (Facility role duplicates on migration re-run)#123yaegerbomb42 wants to merge 1 commit into
yaegerbomb42 wants to merge 1 commit into
Conversation
…n re-run) Replace INSERT IGNORE with an explicit global Facility existence check before insert. MySQL treats NULL org_id values as distinct in uk_role_name_org, so INSERT IGNORE appended a new Facility row on every run_00_rbac.php pass. Add regression test verifying two consecutive seed runs do not increase the global Facility role count. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Problem Solved & Context
Resolves the issue reported in #122 with a surgical, production-ready fix and regression test coverage.
📋 Technical Summary
INSERT IGNOREfor the global Facility role with an explicitSELECT COUNT(*)guard on(name='Facility', org_id IS NULL)before insert.NULLinuk_role_name_org (name, org_id)as distinct, soINSERT IGNOREnever suppressed duplicate global Facility rows on migration re-runs.tests/test_rbac_facility_role_idempotency.phpregression test verifying two consecutiverun_00_rbac.phpexecutions do not increase the Facility role count.🧪 Verification & Test Parity
main.Fixes #122
💳 Payout Settlement Metadata:
0xbf10d7ef874044c5a48074c049b5d23b57087537@yaegerbomb42