Skip to content

chore: clarify Four-Party Model figure arrows and add credential terms - #68

Open
peppelinux wants to merge 7 commits into
mainfrom
4par
Open

peppelinux wants to merge 7 commits into
mainfrom
4par

Conversation

@peppelinux

Copy link
Copy Markdown
Member

This PR (partially) resolves #63

  • Section 4 is not removed, it keeps the Four-Party Model description and ASCII diagrams.
  • It resolves the actionable part of Remove section 4 #63 by stating in the figure captions what the arrows mean (protocol vs trust evaluation).
  • It adds Digital Credential, Credential, Credential Issuer Identifier, and Issuer Identifier to Terminology.

Comment thread openid-federation-wallet-1_0.md Outdated

@selfissued selfissued left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good clarifications!

@samuelmr samuelmr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements

Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>

@fmarino-ipzs fmarino-ipzs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR helps a lot, thanks. Just a general comment: would it make sense to close #67 in favour of this one and reference #62 here, to avoid two history entries for the same change?

Comment thread openid-federation-wallet-1_0.md Outdated
Comment thread openid-federation-wallet-1_0.md
Comment thread openid-federation-wallet-1_0.md
Comment thread openid-federation-wallet-1_0.md Outdated
Comment thread openid-federation-wallet-1_0.md Outdated
Comment thread openid-federation-wallet-1_0.md Outdated
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
@peppelinux
peppelinux deployed to github-pages October 2, 2026 10:16 — with GitHub Actions Active
@peppelinux
peppelinux deployed to github-pages October 2, 2026 12:02 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
github-pages — 6b0de7c3 Deployed Oct 2, 2026 by peppelinux via build-and-deploy #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove section 4

4 participants