Repository navigation
clarify trust_anchor - #52
Merged
Merged
Conversation
lj-raidiam
reviewed
Jul 2, 2026
zachmann
force-pushed
the
gz-require-ta-parameter
branch
from
July 13, 2026 08:53
c2c3fb9 to
2ec5860
Compare
selfissued
reviewed
Oct 8, 2026
selfissued
reviewed
Oct 8, 2026
selfissued
approved these changes
Oct 8, 2026
selfissued
left a comment
selfissued
left a comment
Member
There was a problem hiding this comment.
Please apply my suggestions before merging
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #36
Originally I thought it would be convenient for clients to have the
trust_anchorrequest parameter optional, since I would expect that it is likely to use the same entity that provides the entity collection endpoint as the trust anchor.When thinking about how to clarify #36 I cam to the conclusion that it is probably the best to instead require the
trust_anchorparameter. This makes usage more clear for implementers.