Refactor bookmark export to use QgsVectorFileWriter#7739
Draft
kaustuvpokharel wants to merge 2 commits into
Draft
Refactor bookmark export to use QgsVectorFileWriter#7739kaustuvpokharel wants to merge 2 commits into
kaustuvpokharel wants to merge 2 commits into
Conversation
Collaborator
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 🪟 Windows buildsDownload a Windows build of this PR for testing and for arm64. (Built from commit 2eb16b2) 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor bookmark export and fix drawer-sizing incositency on mobile (just noticed)
Reworks BookmarkModel::exportBookmarks to build the GeoPackage directly with QgsVectorFileWriter (following ProjectUtils::createProject) instead of a memory layer and LayerUtils::saveVectorLayerAs