Fix MapConsistency test: normalize custom_tribes key order to match gen-maps output 🧪

[FloPinguin]

Description:

The info.json metadata matches the generated Maps.gen.ts test in MapConsistency was comparing custom_tribes via JSON.stringify, which is key-order-sensitive. Info.json files store tribes as {"coordinates":[...],"name":"..."} while the gen-maps codegen always outputs {name: "...", coordinates: [...]} (name first). The normalizeCustomTribes function passed through raw objects without reordering keys, causing semantically identical data to fail the string comparison.

This fix explicitly reconstructs custom tribe objects in normalizeCustomTribes with consistent key ordering (name first, then coordinates) to match the gen-maps output format.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 12b64f94-f6fc-4e2c-acb8-68c60c804ebc

📥 Commits

Reviewing files that changed from the base of the PR and between 4f26ee8 and 30e94c2.

📒 Files selected for processing (1)

• tests/MapConsistency.test.ts

---

Walkthrough

normalizeCustomTribes now validates every custom-tribe entry. Valid strings and objects become consistent objects. Invalid values, names, and coordinates throw indexed errors.

Changes

Custom tribe normalization

Layer / File(s)	Summary
Validate and normalize custom tribe entries tests/MapConsistency.test.ts	Empty strings, invalid values, missing or empty names, and malformed coordinates now throw indexed errors. Valid entries retain their name and optional numeric coordinates.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4697: Extends related custom_tribes normalization logic in tests/MapConsistency.test.ts.

Suggested reviewers: evanpelle

Poem

Custom tribes face the test,
Valid shapes pass cleanly best.
Names stay clear, coordinates align,
Bad entries stop at the indexed line.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the MapConsistency test fix and the custom_tribes key-order normalization.
Description check	✅ Passed	The description accurately explains the key-order fix and the added runtime validation for normalizeCustomTribes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/MapConsistency.test.ts`:
- Around line 76-80: The helper that reconstructs custom tribe entries must
validate each entry before accessing properties. Add a runtime guard ensuring
the entry is a non-null object with a valid string name and, when present, valid
coordinates; reject invalid entries by throwing or returning an error, while
preserving the existing name-first reconstruction for valid entries.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 618e6ae9-2891-44ad-8a2e-180e83d3b2af

📥 Commits

Reviewing files that changed from the base of the PR and between 2f48ae9 and 4f26ee8.

📒 Files selected for processing (1)

• tests/MapConsistency.test.ts

[ryanbarlow97]

thanks