Adds map of France - #4747
Merged
Merged
Conversation
RickD004
added
the
Maps
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughAdds a playable France map with regional definitions, map metadata, dimensions, thumbnail, translation, and generated game catalog registration. ChangesFrance map
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/core/game/Maps.gen.ts (1)
50-50: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a registry test for the new map entry.
This changes
src/core/, but no test change is included. Extend the existing generic map-catalog test so it verifiesGameMapType.Franceand themap.francemetadata.Based on coding guidelines, all changes to
src/core/must include tests. Based on learnings, use the existing non-per-map registry assertions instead of adding a dedicated France-only expectation.Also applies to: 512-518
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/game/Maps.gen.ts` at line 50, Extend the existing generic map-catalog registry test to cover GameMapType.France and its map.france metadata, using the established non-per-map assertion pattern rather than adding a France-specific test. Ensure the test confirms the new registry entry is included alongside the existing map entries.Sources: Coding guidelines, Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/core/game/Maps.gen.ts`:
- Line 50: Extend the existing generic map-catalog registry test to cover
GameMapType.France and its map.france metadata, using the established
non-per-map assertion pattern rather than adding a France-specific test. Ensure
the test confirms the new registry entry is included alongside the existing map
entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8db223f8-dec4-4d6a-89d5-a12a5d482cf2
⛔ Files ignored due to path filters (29)
map-generator/assets/maps/france/image.pngis excluded by!**/*.pngresources/flags/Free France.svgis excluded by!**/*.svgresources/flags/Gascony.svgis excluded by!**/*.svgresources/flags/Kingdom of France.svgis excluded by!**/*.svgresources/flags/Napoleon.svgis excluded by!**/*.svgresources/flags/fr-a.svgis excluded by!**/*.svgresources/flags/fr-ara.svgis excluded by!**/*.svgresources/flags/fr-bfc.svgis excluded by!**/*.svgresources/flags/fr-c.svgis excluded by!**/*.svgresources/flags/fr-cvl.svgis excluded by!**/*.svgresources/flags/fr-d.svgis excluded by!**/*.svgresources/flags/fr-g.svgis excluded by!**/*.svgresources/flags/fr-ges.svgis excluded by!**/*.svgresources/flags/fr-hdf.svgis excluded by!**/*.svgresources/flags/fr-i.svgis excluded by!**/*.svgresources/flags/fr-idf.svgis excluded by!**/*.svgresources/flags/fr-k.svgis excluded by!**/*.svgresources/flags/fr-l.svgis excluded by!**/*.svgresources/flags/fr-m.svgis excluded by!**/*.svgresources/flags/fr-naq.svgis excluded by!**/*.svgresources/flags/fr-o.svgis excluded by!**/*.svgresources/flags/fr-pac.svgis excluded by!**/*.svgresources/flags/fr-pdl.svgis excluded by!**/*.svgresources/flags/fr-s.svgis excluded by!**/*.svgresources/flags/fr-t.svgis excluded by!**/*.svgresources/flags/fr-v.svgis excluded by!**/*.svgresources/maps/france/map.binis excluded by!**/*.binresources/maps/france/map16x.binis excluded by!**/*.binresources/maps/france/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (6)
map-generator/assets/maps/france/info.jsonresources/countries.jsonresources/lang/en.jsonresources/maps/france/manifest.jsonresources/maps/france/thumbnail.webpsrc/core/game/Maps.gen.ts
evanpelle
approved these changes
Jul 28, 2026
github-project-automation
Bot
moved this from Triage
to Final Review
in OpenFront Release Management
github-project-automation
Bot
moved this from Final Review
to Complete
in OpenFront Release Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
(maybe) final map for v33. Map of France
Another country map using impassable terrain.
The second largest playerbase is france, only behind the US. As such i think this would be a nice map for the french playerbase, as there are many relevant content creators and players from this country.
(the Didier France map shouldnt clash with this one, as that one has the lowest rotation (1) and only appears in special game modifiers. Majority of the playerbase has probably never even seen it, it should be treated as an easter egg - This acts as the common default map of france)
Old french regions as nations. Custom nations and tribes are planned to be added in the future
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011