"stats" not "ranking"

[ryanbarlow97]

Description:

people confused what "ranking" means on the games stats modal

also sorta helps with the overflow

before:

after:

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

w.o.n

[coderabbitai]

Walkthrough

The game history button now uses the game_list.stats translation key, and the English translation defines that key as “Stats” instead of “Ranking.”

Changes

Game stats label

Layer / File(s)	Summary
Update game stats label resources/lang/en.json, src/client/components/baseComponents/stats/PlayerGameHistoryView.ts	The English game_list translation defines stats, and the game history row button uses game_list.stats.
Estimated code review effort: 1 (Trivial)	~3 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4473: Updated related game_list translation keys used by PlayerGameHistoryView.

Suggested reviewers: evanpelle

Poem

Ranking steps aside,
Stats now shines beside each game,
One key guides the way.
Tiny words, neatly aligned,
Clear labels brighten play.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly reflects the label change from “ranking” to “stats” in the game stats modal.
Description check	✅ Passed	The description matches the UI text update and explains why the label was changed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR aims to reduce confusion in the game stats modal by changing the button label from “Ranking” to “Stats”.

Changes:

• Updated the game history button label to use a new game_list.stats translation key.
• Replaced the English translation entry from game_list.ranking to game_list.stats.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/client/components/baseComponents/stats/PlayerGameHistoryView.ts	Updates the button label translation key from game_list.ranking to game_list.stats.
resources/lang/en.json	Replaces the game_list.ranking entry with game_list.stats.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

🧹 Nitpick comments (1)

src/client/components/baseComponents/stats/PlayerGameHistoryView.ts (1)

215-228: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider renaming showRanking to showStats for consistency.

The button label now says "Stats" but the handler method and its comment still reference "ranking". Renaming would keep the code aligned with the new terminology.

♻️ Optional rename for naming consistency

-  // Opens the game-info ranking overlay on top of the account modal. The modal
-  // is a global singleton in the document (queried the same way as Main.ts),
-  // so we don't close the account modal — the overlay layers above it.
-  private showRanking(gameId: string) {
+  // Opens the game-info stats overlay on top of the account modal. The modal
+  // is a global singleton in the document (queried the same way as Main.ts),
+  // so we don't close the account modal — the overlay layers above it.
+  private showStats(gameId: string) {

And update the call site at line 455:

-              `@click`=${() => this.showRanking(game.gameId)}
+              `@click`=${() => this.showStats(game.gameId)}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/client/components/baseComponents/stats/PlayerGameHistoryView.ts` around
lines 215 - 228, Rename the `showRanking` method in `PlayerGameHistoryView` to
`showStats` and update its surrounding comment so it no longer refers to
“ranking” but matches the current Stats terminology. Also update the call site
that invokes this handler so the new `showStats` name is used consistently
throughout the component.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/client/components/baseComponents/stats/PlayerGameHistoryView.ts`:
- Around line 215-228: Rename the `showRanking` method in
`PlayerGameHistoryView` to `showStats` and update its surrounding comment so it
no longer refers to “ranking” but matches the current Stats terminology. Also
update the call site that invokes this handler so the new `showStats` name is
used consistently throughout the component.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e170890c-6ed9-4503-81a9-71594099eeb6

📥 Commits

Reviewing files that changed from the base of the PR and between c5b2d60 and 13771db.

📒 Files selected for processing (2)

• resources/lang/en.json
• src/client/components/baseComponents/stats/PlayerGameHistoryView.ts