feat: Expand maps button#4431
Conversation
Walkthrough
ChangesMapPicker Expand/Collapse All
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/client/components/map/MapPicker.ts`:
- Around line 78-83: The toggleExpandAll logic in MapPicker is treating any
non-empty expandedCategories Set as “all expanded,” so a partially expanded
state collapses instead of expanding the remaining categories. Update
toggleExpandAll and the related label/rendering logic to compare
expandedCategories.size against allCategories.length, and only collapse when
every category is expanded; otherwise expand all remaining categories.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0ec7531b-03cf-4ff3-8cef-65cc870b4053
📒 Files selected for processing (2)
resources/lang/en.jsonsrc/client/components/map/MapPicker.ts
Description:
QoL fix w.r.t. "All" maps category. Maps used to all be shown in a big list, now the category sections need to be expanded one by one. Categories are super clean and useful, but to visually see and pick maps when you're not certain which one you want to play becomes challenging (to click and expand each category manually). This just adds a simple "Expand All" and "Collapse All" button to the all category list on Solo and Private Match screens.
Screen.Recording.2026-06-27.190000.mp4
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
bijx