feat: add AccountActivationEmailContextGenerated filter - #391
Merged
Merged
Conversation
pwnage101
force-pushed
the
pwnage101/ENT-11816
branch
from
September 3, 2026 18:33
03ea727 to
cf381ea
Compare
pwnage101
force-pushed
the
pwnage101/ENT-11816
branch
from
September 16, 2026 20:59
cf381ea to
2821631
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The filter contract matches its linked consumer, is documented and tested, and all relevant checks pass.
Pull request overview
Adds a public learning filter allowing pipeline steps to enrich account activation email context before rendering and sending.
Changes:
- Adds
AccountActivationEmailComposed. - Tests its filter type and no-pipeline behavior.
- Releases version 3.14.0 with changelog documentation.
File summaries
| File | Description |
|---|---|
openedx_filters/learning/filters.py |
Defines the new activation email filter. |
openedx_filters/learning/tests/test_filters.py |
Covers the new filter’s contract. |
openedx_filters/__init__.py |
Bumps the package version. |
CHANGELOG.rst |
Documents the 3.14.0 release. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pwnage101
marked this pull request as ready for review
September 16, 2026 21:44
This new filter allows pipeline steps to enrich the account activation email context, e.g. to support highly custom account activation email templates (likely supplied by a custom edx-theme). ENT-11816
pwnage101
force-pushed
the
pwnage101/ENT-11816
branch
from
September 16, 2026 22:46
2821631 to
84068e7
Compare
pwnage101
changed the title
brobro10000
approved these changes
Sep 16, 2026
felipemontoya
approved these changes
Sep 17, 2026
felipemontoya
left a comment
felipemontoya
left a comment
Member
There was a problem hiding this comment.
I was looking at both this PR and the example implementation that will be used for the platform https://github.com/edx/edx-platform/pull/425/changes and they look clean and correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new filter
AccountActivationEmailComposedwith typeorg.openedx.learning.account.activation.email.compose.v1to allow plugins to augment the account activation email context payload.ENT-11816
These should be merged together:
is_enterprise_learnerhint edx-enterprise#2674