Ent 11150 unsubmitted courses fix - #1115
tpanda-sonata wants to merge 2 commits into
Conversation
…MS discovery mechanism
| # to ensure active content is always returned | ||
| # to ensure active content is always ret |
There was a problem hiding this comment.
This looks like an accidental deletion of text.
There was a problem hiding this comment.
Rejected for now because I think is_active is too upstream and risky to change. 3rd part LMS integrations should use a customized implementation to avoid inadvertent modification of other content APIs.
More info here: https://2u-internal.atlassian.net/browse/ENT-11150?focusedCommentId=5762901
|
@tpanda-sonata @pwnage101 Hi, hope that you two are doing well. While checking this PR, I think this is also being handled here #1132, what would you think of moving forward with that PR instead? |
|
Thanks for the pull request, @tpanda-sonata! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Overview
This PR fixes the issue where unsubmitted / unpublished courses were being included
in the Enterprise Catalog report.
During catalog metadata generation, these courses should be excluded to prevent
incorrect content appearing in downstream systems.
What Was Changed
JIRA: ENT-11150