Skip to content

Ent 11150 unsubmitted courses fix - #1115

Open
tpanda-sonata wants to merge 2 commits into
openedx:masterfrom
tpanda-sonata:ENT-11150-unsubmitted-courses-fix
Open

tpanda-sonata wants to merge 2 commits into
openedx:masterfrom
tpanda-sonata:ENT-11150-unsubmitted-courses-fix

Conversation

@tpanda-sonata

Copy link
Copy Markdown

Overview

This PR fixes the issue where unsubmitted / unpublished courses were being included
in the Enterprise Catalog report.
During catalog metadata generation, these courses should be excluded to prevent
incorrect content appearing in downstream systems.

What Was Changed

  • Updated filtering logic in content metadata API to exclude:
    • Unsubmitted course runs
    • Draft / unpublished course versions
  • Added validation to ensure catalog content only includes production-ready items
  • Minor code cleanup for readability

JIRA: ENT-11150

Comment on lines -244 to +247
# to ensure active content is always returned
# to ensure active content is always ret

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental deletion of text.

@pwnage101 pwnage101 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected for now because I think is_active is too upstream and risky to change. 3rd part LMS integrations should use a customized implementation to avoid inadvertent modification of other content APIs.

More info here: https://2u-internal.atlassian.net/browse/ENT-11150?focusedCommentId=5762901

@alexjmpb

Copy link
Copy Markdown
Contributor

@tpanda-sonata @pwnage101 Hi, hope that you two are doing well. While checking this PR, I think this is also being handled here #1132, what would you think of moving forward with that PR instead?

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 11, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @tpanda-sonata!

This repository is currently maintained by @alexjmpb.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Sep 11, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

5 participants