Repository navigation
Conversation
When the system has no huge page sizes available (e.g. /sys/kernel/mm/hugepages is absent in a build environment), cgroups.HugePageSizes returns an empty list, and HugetlbGroup's Set and GetStats are no-ops. As a result, the tests which expect GetStats to fail are failing, and the rest are passing vacuously. Skip all hugetlb tests in such case. Reported in opencontainers/runc#1822. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Some hugetlb tests use file name templates such as "hugetlb.%s.max_usage_in_bytes" as is, without substituting the page size. As a result, TestHugetlbStatsBadMaxUsageFile fails because the usage file is not found, rather than because the max usage file contents can't be parsed, and so it does not test what it is supposed to test. Fix this (and similar issues in other tests) by using proper file names for every available huge page size. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
AkihiroSuda
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip hugetlb tests if the system has no huge page sizes available (e.g. no
/sys/kernel/mm/hugepagesin a build environment). Without this,TestHugetlbStats{NoUsageFile,NoMaxUsageFile,BadUsageFile,BadMaxUsageFile}fail, sinceGetStatsis a no-op in this case, and the rest are passing vacuously.Fixes hugetlb_test fails on [ppc64el, s390x] runc#1822.
Fix file names in hugetlb failure tests. Some tests used the file name template (like
hugetlb.%s.max_usage_in_bytes) as is, so e.g.TestHugetlbStatsBadMaxUsageFilefailed because the usage file was not found, rather than because max usage can't be parsed.