Repository navigation
Conversation
Move the code which chowns the cgroup v2 directory and its delegatable files to the owner UID from systemd's UnifiedManager.Apply to a new internal package, so it can be reused by fs2 manager. No functional change. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Cgroup ownership (chowning the container's cgroup to the host UID mapped to the container's root, in case the container has a private cgroup namespace and a read-write cgroupfs) was only implemented for systemd cgroup v2 manager. Implement it for fs2 manager as well. Add a test case. Fixes: opencontainers#66 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cgroup ownership (chowning the container's cgroup to the host UID mapped
to the container's root user, when the container has a private cgroup
namespace and a read-write cgroupfs) was only implemented for the systemd
cgroup v2 manager; fs2 manager silently ignored
OwnerUID.This PR:
UnifiedManager.Applyto a newinternal/delegatepackage (no functional change);Manager.Apply, and adds a test case;OwnerUIDdocumentation.Fixes: #66