feat(PBV): improve goal state for better error messages - #1488
Merged
Merged
Conversation
luigirinaldi
added this pull request to stack #1484
September 17, 2026 21:38
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-debug
branch
from
September 17, 2026 22:08
e51badd to
68d05ba
Compare
luigirinaldi
marked this pull request as ready for review
September 17, 2026 22:08
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-debug
branch
2 times, most recently
from
September 21, 2026 13:27
4db4444 to
4b85a8b
Compare
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-debug
branch
from
September 21, 2026 13:32
4b85a8b to
bfb8b56
Compare
naveen-seth
approved these changes
Sep 21, 2026
naveen-seth
left a comment
naveen-seth
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a small comment
tobiasgrosser
approved these changes
Sep 23, 2026
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-debug
branch
from
September 23, 2026 16:36
bfb8b56 to
64f3f3f
Compare
tobiasgrosser
pushed a commit
that referenced
this pull request
Sep 24, 2026
Remove reference to `maskOfWidth n` in the generated goal state. If all operations were correctly translated and `bv_decide` finds a counterexample there are no longer any "unsupported expressions abstracted as opaque variables". - Redefine `var_elim` to not have `maskOfWidth` in the statement - Rewrite `maskOfWidth`s in the context by adding the hypothesis in the simp set - Add a pass to clear out hypothesis that are no longer needed --------- Co-authored-by: luigirinaldi <luigirinaldi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove reference to
maskOfWidth nin the generated goal state. If all operations were correctly translated andbv_decidefinds a counterexample there are no longer any "unsupported expressions abstracted as opaque variables".var_elimto not havemaskOfWidthin the statementmaskOfWidths in the context by adding the hypothesis in the simp set