feat(PBV): Support Nat literals in width expressions - #1483
Merged
luigirinaldi merged 5 commits intoSep 21, 2026
Merged
Conversation
luigirinaldi
added this pull request to stack #1484
September 17, 2026 12:10
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-width-lit
branch
from
September 17, 2026 12:20
efcfa54 to
de752e0
Compare
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-width-lit
branch
5 times, most recently
from
September 17, 2026 22:07
12f593a to
c871f17
Compare
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-width-lit
branch
from
September 17, 2026 22:08
c871f17 to
fcc501b
Compare
luigirinaldi
marked this pull request as ready for review
September 17, 2026 22:08
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-width-lit
branch
from
September 18, 2026 15:00
fcc501b to
9aba665
Compare
tobiasgrosser
approved these changes
Sep 19, 2026
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-width-lit
branch
from
September 21, 2026 09:32
9aba665 to
1f4dbf2
Compare
An error occurred while trying to automatically change base from
luigirinaldi/bpbv-fix-width-bound
to
main
September 21, 2026 09:59
tobiasgrosser
pushed a commit
that referenced
this pull request
Sep 24, 2026
Support width literals in `pbv_decide`. Hypothesis and concrete width
terms are now correctly handled and translated into facts that
`bv_decide` can reason about.
The following changes were made:
- Extend `Tm` to support width literals, expand reification other `Tm`
related functions accordingly.
- Generate proofs for literal masks (requires `@[expose]`ing the
`maskOfWidth` definition)
- Define a new `introMaskLit` which constructs the proof about the mask
literal
- Update `WidthInfo` to remove unused field, and turn `MVarId` field
into an option
- This led to updating the `runGrind` function
- Add some tests.
---------
Co-authored-by: luigirinaldi <luigirinaldi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support width literals in
pbv_decide. Hypothesis and concrete width terms are now correctly handled and translated into facts thatbv_decidecan reason about.The following changes were made:
Tmto support width literals, expand reification otherTmrelated functions accordingly.@[expose]ing themaskOfWidthdefinition)introMaskLitwhich constructs the proof about the mask literalWidthInfoto remove unused field, and turnMVarIdfield into an optionrunGrindfunction