Skip to content

Preserve late steer after turn finalization#30341

Open
friel-openai wants to merge 2 commits into
mainfrom
dev/friel/preserve-late-steer-after-turn-finalization
Open

Preserve late steer after turn finalization#30341
friel-openai wants to merge 2 commits into
mainfrom
dev/friel/preserve-late-steer-after-turn-finalization

Conversation

@friel-openai

Copy link
Copy Markdown
Contributor

Summary

  • atomically detect user input accepted while a regular task is finalizing
  • continue that task before exposing the thread as idle
  • add a deterministic regression proving the steer is sampled exactly once and retains its client message ID

Related: #15842, #14054, #14404

Testing

  • RUST_MIN_STACK=8388608 cargo test -p codex-core pending_input -- --nocapture
  • cargo test -p codex-app-server turn_steer
  • just fix -p codex-core
  • just fmt

just argument-comment-lint -p codex-core is currently blocked because the repository pins nightly Rust 1.92 while SQLx 0.9 requires Rust 1.94. The changed call sites follow the argument-comment convention.

@friel-openai friel-openai marked this pull request as ready for review June 27, 2026 06:41
@friel-openai friel-openai requested a review from a team as a code owner June 27, 2026 06:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5d74b9b3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/session/tests.rs

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 875de1ec11

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itxaiohanglover

Copy link
Copy Markdown

Good fix with thorough test coverage! The PendingInputContinuationTask test scenario verifies that late steer input is preserved after turn finalization. The is_empty helper on TurnInputQueue is a clean addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants