[codex] Add generated token auth to app-server WebSockets#30315
Draft
mikhail-oai wants to merge 7 commits into
Draft
[codex] Add generated token auth to app-server WebSockets#30315mikhail-oai wants to merge 7 commits into
mikhail-oai wants to merge 7 commits into
Conversation
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenquery parameter when generated-token authentication is active--no-token-check, which still generates and prints the token but accepts missing or incorrect tokens with a warning for every affected connectionMotivation
Loopback app-server WebSocket listeners previously accepted connections without a per-process secret. A generated capability in the connection URL prevents unrelated local clients from connecting by default while keeping startup and client configuration simple. Printing the same URL shape in every mode also gives launchers a consistent startup contract.
User impact
Starting
codex app-server --listen ws://127.0.0.1:4500always prints a URL such as:The query token is enforced by default.
--no-token-checkdisables that enforcement. Explicit--ws-authmodes also disable query-token enforcement and continue to require their configured bearer authentication.Validation
just test -p codex-app-server-transport(126 tests)just test -p codex-app-server websocket_transport_(14 focused WebSocket tests)just test -p codex-cli app_server_no_token_check(2 tests)just fix -p codex-app-server-transport -p codex-app-server -p codex-clijust fmt