core-skills: cache snapshots before root discovery#30281
Draft
anp-oai wants to merge 1 commit into
Draft
Conversation
7acfe82 to
17a9b14
Compare
17a9b14 to
665db63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intent
Config-aware skill snapshots were cached only after rediscovering repo skill roots. On remote filesystems, that repeated metadata probes during session initialization and every turn even when the snapshot itself was reused. Align root discovery with the snapshot cache lifecycle.
implementation
SkillsService::clear_cache()as the shared invalidation boundary.manual validation
just test -p codex-core-skills skills_for_config_keeps_repo_root_discovery_with_snapshot_cache_lifecycle