Skip to content

core-skills: cache snapshots before root discovery#30281

Draft
anp-oai wants to merge 1 commit into
mainfrom
codex/cache-skill-root-lifecycle
Draft

core-skills: cache snapshots before root discovery#30281
anp-oai wants to merge 1 commit into
mainfrom
codex/cache-skill-root-lifecycle

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

intent

Config-aware skill snapshots were cached only after rediscovering repo skill roots. On remote filesystems, that repeated metadata probes during session initialization and every turn even when the snapshot itself was reused. Align root discovery with the snapshot cache lifecycle.

implementation

  • Key the config snapshot cache from skill-relevant inputs before filesystem I/O.
  • Store the filesystem identity with each cache entry so snapshots do not cross filesystem handles.
  • Return cache hits before remote root discovery and keep SkillsService::clear_cache() as the shared invalidation boundary.
  • Cover an absent repo skill root becoming visible after cache invalidation.

manual validation

  • just test -p codex-core-skills skills_for_config_keeps_repo_root_discovery_with_snapshot_cache_lifecycle

@anp-oai anp-oai force-pushed the codex/cache-skill-root-lifecycle branch from 7acfe82 to 17a9b14 Compare June 26, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant