Cache remote Bash environment exports#30252
Draft
jif-oai wants to merge 1 commit into
Draft
Conversation
jif-oai
force-pushed
the
jif/remote-bash-env-snapshot
branch
from
2b4e2e0 to
8ba845c
Compare
jif-oai
force-pushed
the
jif/remote-bash-env-snapshot
branch
from
8ba845c to
6a501fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
App/SSH environments cannot inherit the already-initialized terminal environment, so each fresh Bash currently sources the workspace BASH_ENV again. This keeps the fix intentionally narrow: exported variables and PATH only, with no shell-state serializer, temp snapshot files, or command replay.
The one-time initializer runs through the same executor-side sandbox and managed-network preparation as the real command. The original command argv is then launched unchanged with BASH_ENV removed.