[rmcp-client] Test MCP OAuth concurrency and recovery#30089
Open
stevenlee-oai wants to merge 1 commit into
Open
[rmcp-client] Test MCP OAuth concurrency and recovery#30089stevenlee-oai wants to merge 1 commit into
stevenlee-oai wants to merge 1 commit into
Conversation
aa94ede to
d6434ec
Compare
6161cf2 to
ce7b286
Compare
d6434ec to
64f9f77
Compare
ce7b286 to
72603dd
Compare
This was referenced Jun 25, 2026
64f9f77 to
6bf5882
Compare
72603dd to
61abba3
Compare
6bf5882 to
7b4f748
Compare
61abba3 to
f947f83
Compare
7b4f748 to
dd9a13b
Compare
f947f83 to
2e9465b
Compare
dd9a13b to
0b3dcef
Compare
2e9465b to
6741493
Compare
dd9a13b to
52e1548
Compare
52e1548 to
6bb89cb
Compare
6741493 to
b296b36
Compare
6bb89cb to
6705ef7
Compare
b296b36 to
5d03b4e
Compare
6705ef7 to
44d29b6
Compare
5d03b4e to
e864f5c
Compare
44d29b6 to
2e6a3e1
Compare
e864f5c to
8d833da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex Thread 019edd6d-6f14-74e2-853c-345d1803d4a6
Important
This PR belongs to the superseded MCP OAuth stack. Please review and merge the replacement stack beginning with openai/codex#30292. This PR remains available only as historical/reference context.
Replacement review order:
This is part 5 of a five-PR stack that prevents concurrent MCP OAuth refreshes from replaying a rotating refresh token or overwriting newer credentials. This layer is test-only.
Review order
Autoresolution driftWhy
The final ownership boundary spans cross-process storage, public operations, and RMCP-internal traffic. These tests exercise the complete stack once, through the real Streamable HTTP adapter where applicable, without obscuring the production layers with repeated fixtures.
What is covered
Autosource selection and lifecycle pinning.WouldBlockbranch.WouldBlockbranch.Decisions encoded by these tests
RmcpClient; RMCP-owned Response/Error, GET/reconnect, and DELETE recover in the wrapper.Autois lifecycle-local and never hot-switches within one client.Review focus
This PR should contain tests only. Review whether each race synchronizes on the behavior it claims to exercise, whether adapter-level scenarios assert the bearer token used after recovery, and whether provider refresh counts rule out duplicate rotation.
Validation
just test -p codex-rmcp-client: 113 passed, 8 skipped.