Skip to content

Fix duplicate SessionStart exports in CLAUDE_ENV_FILE #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manavagarwal123 wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −1
Open

Fix duplicate SessionStart exports in CLAUDE_ENV_FILE #668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40bf9da
Fix duplicate SessionStart exports in CLAUDE_ENV_FILE
manavagarwal123 Aug 22, 2026
77d09cf
Handle repeated SessionStart environment updates
manavagarwal123 Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion plugins/codex/scripts/session-lifecycle-hook.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,28 @@ function appendEnvVar(name, value) {
if (!process.env.CLAUDE_ENV_FILE || value == null || value === "") {
return;
}
fs.appendFileSync(process.env.CLAUDE_ENV_FILE, `export ${name}=${shellEscape(value)}\n`, "utf8");

const line = `export ${name}=${shellEscape(value)}`;

let lines = [];

try {
lines = fs
.readFileSync(process.env.CLAUDE_ENV_FILE, "utf8")
.split("\n")
.filter(Boolean)
.filter((l) => !l.startsWith(`export ${name}=`));
} catch {
// File doesn't exist yet.
}

lines.push(line);

fs.writeFileSync(
process.env.CLAUDE_ENV_FILE,
lines.join("\n") + "\n",
"utf8"
Comment on lines +56 to +59

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve concurrent updates to the shared env file

When another SessionStart hook writes to the shared CLAUDE_ENV_FILE after this process reads it but before this call, the full-file overwrite silently discards that hook's exports. Matching hooks can execute concurrently, and this hook performs the vulnerable read-modify-write cycle three times, so users with multiple SessionStart hooks can intermittently lose unrelated environment variables; synchronize the update or retain append-only writes rather than replacing the shared file.

Useful? React with 👍 / 👎.

@manavagarwal123 manavagarwal123 Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex address that feedback

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

To use Codex here, create a Codex account and connect to github.

);
}

function cleanupSessionJobs(cwd, sessionId) {
Expand Down