You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct ENABLE_OAUTH_PERSISTENT_CONFIG in the SSO troubleshooting guide to match the env configuration reference and SSO guide default (true).
Clarify when OAuth values come from the database vs environment variables.
Update the Docker Compose note and troubleshooting summary so false is presented as an explicit env-only choice, not the default.
Why
The troubleshooting page currently says ENABLE_OAUTH_PERSISTENT_CONFIG defaults to false, while both the environment configuration reference and SSO guide document the default as true. This can make operators choose the wrong source of truth when debugging OAuth settings that were previously saved through the Admin Panel.
With the default false, oauth.-prefixed settings are read from environment variables and are not loaded from the database, even when ENABLE_PERSISTENT_CONFIG is true. So env vars stay authoritative for OAuth by default, which is what this page already says. Flipping it to "the database wins by default" would point people debugging OAuth in the wrong direction.
The page that was actually wrong is the env-configuration reference (it listed the default as True); that has been corrected, so both pages now agree on false and the mismatch that prompted this PR is resolved.
Closing for that reason. The comparison table was a good idea, though, feel free to resubmit it with false marked as the default row and we'll take it. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_OAUTH_PERSISTENT_CONFIGin the SSO troubleshooting guide to match the env configuration reference and SSO guide default (true).falseis presented as an explicit env-only choice, not the default.Why
The troubleshooting page currently says
ENABLE_OAUTH_PERSISTENT_CONFIGdefaults tofalse, while both the environment configuration reference and SSO guide document the default astrue. This can make operators choose the wrong source of truth when debugging OAuth settings that were previously saved through the Admin Panel.Checks
npx prettier --check docs/troubleshooting/sso.mdx