Skip to content

feat: Add pysfcgal port#228

Merged
m-kuhn merged 1 commit into
open-vcpkg:mainfrom
ptitjano:pysfcgal
Jul 1, 2026
Merged

feat: Add pysfcgal port#228
m-kuhn merged 1 commit into
open-vcpkg:mainfrom
ptitjano:pysfcgal

Conversation

@ptitjano

@ptitjano ptitjano commented May 14, 2026

Copy link
Copy Markdown
Contributor

@3nids

3nids commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

is there any plan to follow-up here?

@ptitjano

Copy link
Copy Markdown
Contributor Author

is there any plan to follow-up here?

Yes, I have just updated to PySFCGAL 2.3

@m-kuhn

m-kuhn commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

There are some failing checks, can you have a look at them?

@ptitjano

Copy link
Copy Markdown
Contributor Author

The CI fails because arm build of SFCGAL is disabled at the moment. This will be fixed with microsoft/vcpkg#52571

@m-kuhn

m-kuhn commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@ptitjano thanks, do you want to wait for this to be accepted upstream or should we mask the tests here (if possible, I'd go for the first option)?

@ptitjano

Copy link
Copy Markdown
Contributor Author

@ptitjano thanks, do you want to wait for this to be accepted upstream or should we mask the tests here (if possible, I'd go for the first option)?

let's wait for upstream changes

@ptitjano

ptitjano commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

arm support of SFCGAL is now merged

@m-kuhn

m-kuhn commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Waiting for #260

@m-kuhn m-kuhn closed this Jun 26, 2026
@m-kuhn m-kuhn reopened this Jun 26, 2026
@m-kuhn m-kuhn enabled auto-merge June 26, 2026 11:29
auto-merge was automatically disabled June 26, 2026 11:59

Head branch was pushed to by a user without write access

@ptitjano

Copy link
Copy Markdown
Contributor Author

pushed a new version which should solve compilation on macos

@ptitjano

Copy link
Copy Markdown
Contributor Author

pushed a new version which should solve compilation on macos

This fixed the compilation but I forgot to run x-add-version. This should be good now

@m-kuhn m-kuhn merged commit b2f7537 into open-vcpkg:main Jul 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants