Skip to content

feat: expose Duration field on Result struct - #54

Open
AdamMagued wants to merge 1 commit into
olebedev:masterfrom
AdamMagued:feat-issue-33-result-duration
Open

AdamMagued wants to merge 1 commit into
olebedev:masterfrom
AdamMagued:feat-issue-33-result-duration

Conversation

@AdamMagued

Copy link
Copy Markdown

Fixes #33

Expose Duration time.Duration on Result in when.go. Populate Result.Duration from rules.Context.Duration after rule evaluation.

Background:
Issue #33 requested ability to determine duration distance from reference dates or capture relative intervals without discarding time delta information. Rules for deadlines, past time, casual dates, and weekdays already accumulate deltas into rules.Context.Duration, but Result previously discarded this value.

Changes:

  • Add Duration time.Duration field to Result struct in when.go.
  • Assign res.Duration = ctx.Duration in Parser.Parse.
  • Add test suite in when_test.go covering relative deadlines, past times, casual dates, static reference date offsets, absolute times, and custom duration rules.

@AdamMagued
AdamMagued requested a review from olebedev as a code owner October 10, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can it determine distance from a static date?

1 participant