chore(release): flag the rich-text and hyperlink changes as minor - #127
Merged
Conversation
CLAUDE.md: pre-1.0, a change to existing behaviour is a clearly flagged minor,
not a patch. Two of the eight fixes qualify — a rich-text cell now reads back
as { kind: 'rich-text' } instead of the concatenated string (#114), and
authoring a hyperlink now throws on a target that used to be accepted (#117).
Both changesets say so explicitly, so the release lands as 0.10.0.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SjUPLwF71C5DapaqsL3gw8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marks two of the eight round-trip fixes that just landed as
minorrather thanpatch, and spells out the behaviour change in each changeset. The releasethis produces is
0.10.0, not0.9.3.Motivation
CLAUDE.md's OSS discipline section says a change to existing behaviour is a
breaking change — "major bump (post-1.0) or clearly flagged minor (pre-1.0)".
Two of the fixes change behaviour a caller can observe, and I filed both as
patch:{ kind: 'rich-text', runs }where it used to read back as the concatenatedplain string. Anything doing
getCell(…).valueon such a cell and treatingit as a string is affected. Rich-text cells also now serialise into
xl/sharedStrings.xmlinstead of ast="inlineStr".makeHyperlink/setHyperlink/addUrlHyperlink/addMailtoHyperlinknow throw on a target they previously accepted.Shipping either as a patch would put a surprise in a version users expect to be
safe.
No issue: this corrects changeset metadata from PRs #122 and #124 before the
"Version Packages" PR is merged.
Changes
.changeset/fix-shared-string-rich-text.mdand.changeset/fix-hyperlink-target-validation.mdbumped frompatchtominor, each with a Behaviour change paragraph naming what moves and whois affected.
The other six fixes stay
patch— they change what is written to the packageto match what Excel wrote, without changing an API contract.
Testing
Metadata only; no source touched.
changesetsrecomputes the release PR to0.10.0on merge.Breaking changes
None introduced here. This PR is what makes the already-merged behaviour
changes visible in the version number and the changelog.
Checklist
flagged it above.
represents real work that warrants a maintainer's review, and I am willing to
defend each line in review.