[ADD] module: add new module real estate (Onboarding)#1238
[ADD] module: add new module real estate (Onboarding)#1238
Conversation
5d0a3ce to
aeda88e
Compare
|
Hello there ! Good work already, just added a few comments. Also it seems your first commit has the wrong author set (most probably because your config was not properly set before pushing, might want to check into this as a general git exercise) |
delcourtfl
left a comment
There was a problem hiding this comment.
Hello there ! Good work already, just a few comments.
(Might also need to check runbot style CI for some additional issues)
6c038b6 to
014cf91
Compare
There was a problem hiding this comment.
Hello there ! Really good work, not much to say, you got the general idea for module development.
Also to end this part in a clean way you should squash your commits (using an interactive rebase) into:
- one for estate module
- one for estate_account module
(And don't forget to check the runbot style CI 👀)
20caa13 to
9a36ad0
Compare
9a36ad0 to
5dfd3fb
Compare
|
Hi @delcourtfl , Thank you so much for checking my PR. I really appreciate you taking the time to review it and giving detailed feedback on the parts I missed. |


Create Real Estate Module for onboarding program