Skip to content

[ADD] module: add new module real estate (Onboarding)#1238

Open
yogietama wants to merge 3 commits intoodoo:19.0from
odoo-dev:19.0-onboarding-yomet
Open

[ADD] module: add new module real estate (Onboarding)#1238
yogietama wants to merge 3 commits intoodoo:19.0from
odoo-dev:19.0-onboarding-yomet

Conversation

@yogietama
Copy link
Copy Markdown

Create Real Estate Module for onboarding program

@robodoo
Copy link
Copy Markdown

robodoo commented Apr 21, 2026

Pull request status dashboard

@yogietama yogietama requested a review from delcourtfl April 21, 2026 15:16
@yogietama yogietama force-pushed the 19.0-onboarding-yomet branch 2 times, most recently from 5d0a3ce to aeda88e Compare April 22, 2026 08:37
Comment thread estate/__manifest__.py Outdated
Comment thread estate/models/__init__.py Outdated
Comment thread estate/__manifest__.py Outdated
Comment thread estate/__manifest__.py Outdated
Comment thread estate/views/estate_property_views.xml Outdated
Comment thread estate/views/estate_property_views.xml Outdated
Comment thread estate/models/estate_property.py
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/__manifest__.py Outdated
@delcourtfl
Copy link
Copy Markdown

Hello there ! Good work already, just added a few comments.

Also it seems your first commit has the wrong author set (most probably because your config was not properly set before pushing, might want to check into this as a general git exercise)

Copy link
Copy Markdown

@delcourtfl delcourtfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there ! Good work already, just a few comments.

(Might also need to check runbot style CI for some additional issues)

Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_propery_offer.py
Comment thread estate/models/estate_propery_offer.py Outdated
Comment thread estate/models/estate_propery_offer.py Outdated
Comment thread estate/security/ir.model.access.csv Outdated
Comment thread estate/__manifest__.py Outdated
@yogietama yogietama force-pushed the 19.0-onboarding-yomet branch 5 times, most recently from 6c038b6 to 014cf91 Compare April 29, 2026 09:39
Copy link
Copy Markdown

@delcourtfl delcourtfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there ! Really good work, not much to say, you got the general idea for module development.

Also to end this part in a clean way you should squash your commits (using an interactive rebase) into:

  • one for estate module
  • one for estate_account module

(And don't forget to check the runbot style CI 👀)

Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_propery_offer.py Outdated
Comment thread estate/models/estate_propery_offer.py Outdated
Comment thread estate/views/estate_property_menu.xml Outdated
Comment thread estate_account/models/estate_property.py Outdated
@yogietama yogietama force-pushed the 19.0-onboarding-yomet branch 2 times, most recently from 20caa13 to 9a36ad0 Compare April 30, 2026 08:07
@yogietama yogietama force-pushed the 19.0-onboarding-yomet branch from 9a36ad0 to 5dfd3fb Compare April 30, 2026 08:16
@yogietama
Copy link
Copy Markdown
Author

Hi @delcourtfl ,
I've already updated and improved the code to address potential performance issues. I also squashed the commits into the estate and estate_account modules. The Runbot style checks passed! :)

Thank you so much for checking my PR. I really appreciate you taking the time to review it and giving detailed feedback on the parts I missed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants