ci: remove release-please, keep tag-driven hatch-vcs releases#44
Merged
Conversation
The package version is now derived from git tags by hatch-vcs (release.yml), which is incompatible with release-please's model of bumping [project].version in pyproject.toml. Remove the redundant/conflicting release-please system: changelog.yml, publish.yml (superseded by release.yml), tag-on-bump.yml (would KeyError on the now-dynamic version), and the release-please config + manifest. Releases are cut by creating a GitHub Release vX.Y.Z.
Make the Versioning section dense and accurate after dropping release-please: name release.yml as the single release path, the PyPI Trusted Publishing prerequisite, and the PR-time reminder hook; drop the chatty phrasing.
Whole-file pass: trim the header boilerplate, tighten the operator-forms and connector descriptions, and de-duplicate the bridge-stderr rule (kept once in the load-bearing invariants, cross-referenced from Conventions). Fact-dense sections (Commands, tests notes, architecture map, invariants) left verbatim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #43. The repo had a parallel release-please system (
changelog.yml,publish.yml,tag-on-bump.yml+ config/manifest) that landed onmainconcurrently with the hatch-vcs migration. The two are mutually incompatible — release-please bumps[project].versioninpyproject.toml, which #43 made dynamic. Per decision, we keep the tag-driven hatch-vcs model and remove release-please.Removes:
.github/workflows/changelog.yml(release-please release-PR).github/workflows/publish.yml(superseded byrelease.yml— both published to PyPI envpypi, would double-fire).github/workflows/tag-on-bump.yml(reads[project].versionvia tomllib → KeyError now that it's dynamic)release-please-config.json,.release-please-manifest.jsonAfter this, the single release path is: create a GitHub Release
vX.Y.Z→release.ymlbuilds (hatch-vcs derives the version from the tag), publishes to PyPI, attaches artifacts.Test plan
release.ymlis now the only PyPI-publishing workflow.