androidSdk/bin/emulator support#523
Draft
kolchurinvv wants to merge 2 commits intonvim-flutter:mainfrom
Draft
Conversation
Author
|
@sidlatau sorry for the direct '@' -- only want to make sure this has been noticed :) would love to hear thoughts :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WHY
For whatever reason my NixOS +
nix developshell which encapsulates my flutter project doesn't want to load qemu aka emulators into the Nvidia VRAM when launched viaflutter emualtor --launch emulator_id, but theemulator @emulator_id -gpu host -accel onworks like a charm.The intention of the Draft PR is to gauge whether this affects other people and could be useful to a wider audience 😄
There could be potential to capture user input to extend the launch options with the ones listed in
emulator --helpThis adds a rudimentary support for
**/*/androidSdk/bin/emulatorbinary.-gpu host,-accel onand others - currently hard-coded what i needed.emulatorbinaryemulator @emulator_id.. argsknown issues:
emulatorbinary is used to launch the emulators, on closing the emulator, the entire log is pushed to the Notifications. I'm not sure what would be the best way to handle thisprobablybreak on MacOS - haven't tested it there (i do have a mac so i will be able to test there soon)