Add OMM format support - #72
Draft
jerematt wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for providing the satellite orbital parameters in OMM dictionary/JSON format instead of TLE.
The interface retains the same TLE support as it did before, allowing TLE's to be passed in as strings or a list of strings for each line.
OMM data would be passed in as a dictionary containing the standard OMM JSON elements defined by CCSDS, any extra keys are silently ignored. Handles both SpaceTrack and Celestrak-style JSON OMM (where the values are either quoted strings or Numbers/Integers).
Fixes the Makefile, and adds some tests for the above. Also removed a lot of unused code from within predict.c
Bumps version to 2.0.0 - whilst technically the python/user-level API hasnt been broken, the underlying Python-C API has changed, and the change overall is big enough to merit a major bump.
One minor API change - in the returned observation objects, when using python3,
visibilitynow returns a one-character str rather than a one-character byte as it did before. This makes it consistent with python2 behaviour, and allows the output to be more easily serialized by json and other formats which may not be able to encode bytes directly.