Repository navigation
Conversation
Signed-off-by: ychampion <68075205+ychampion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh
npm install primeng@18.0.2can select Angular common 19 alongside core 18, then fail with ERESOLVE even though common 18 satisfies the peer group.When a missing required peer has no direct constraint on its virtual parent, consult a sibling peer constraint before recursively loading the candidate’s own peers.
Reuse the existing two-edge version selection, retaining direct-parent priority and the skip for absent optional peers.
Fixes #10054.
Validation:
npm ls --all --jsonreports no problems.Full validation:
node . run test-allexecuted the CLI, docs, smoke tests and all workspaces.The initial run hit Arborist’s chmod/EACCES assertion because this session runs as root, plus a 30-second file timeout in libnpmexec; the other suites passed.
Rerunning the full Arborist suite with DAC bypass capabilities removed and the full libnpmexec suite with a 120-second timeout passed, each with 100% coverage and lint/template checks.
Assisted by AI.