Repository navigation
fix(arborist): use live metadata for shrinkwrap lookups - #10276
Open
jeffwidman wants to merge 1 commit into
Open
jeffwidman wants to merge 1 commit into
jeffwidman wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shrinkwrap#get()prefer currentpackagesdata, then metadata from the attached live tree, before falling back to legacy lockfile datatree.root.realpathcoordinates for live inventory lookupsadd()hydration on persisted metadata so an incomplete node cannot mask legacyresolvedorintegrityvaluesDesign choice
The existing Arborist README describes
node.metaas looking upresolvedandintegrityvalues for all modules in the tree. This change treats an attached tree as part of that lookup contract rather than returning stale legacy metadata when the modernpackagesentry is absent.That is an API/behavior choice for maintainer discussion, not an assumption that the implementation must change:
This is the standalone bug-fix portion split from #10130. It intentionally excludes the v3+ legacy traversal and serialization optimization so the two decisions can be reviewed independently.
Testing
tap --no-coverage test/shrinkwrap.js test/node.jseslint lib/shrinkwrap.js test/shrinkwrap.jsadd()uses live lookup during hydrationgit diff --check