Repository navigation
chore(arborist): make getBundler traversal Set-only - #10274
Closed
jeffwidman wants to merge 1 commit into
Closed
jeffwidman wants to merge 1 commit into
jeffwidman wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jeffwidman
changed the title
Contributor
|
Let's keep it as is. Someone could in theory be calling it and I don't want to introduce unnecessary risk. Thanks for being persistent and following up here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm/cli#10127 changed
Node#getBundler()to use aSetfor normal traversal, but intentionally retained precautionary compatibility for callers that explicitly pass an array.This follow-up treats the optional traversal argument as internal recursion state and makes it Set-only. It removes the array-specific branch and the compatibility-only regression test, while preserving the default traversal behavior.
The compatibility question and tradeoff were discussed in this comment. This PR leaves it to maintainers to decide whether and when that API simplification is appropriate.
Validation
node --check workspaces/arborist/lib/node.jsnode --check workspaces/arborist/test/node.js