doc,src,test: fix dead inspector help URL#62745
Open
semimikoh wants to merge 2 commits intonodejs:mainfrom
Open
doc,src,test: fix dead inspector help URL#62745semimikoh wants to merge 2 commits intonodejs:mainfrom
semimikoh wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
semimikoh
force-pushed
the
fix/inspector-dead-help-link
branch
from
f955be0 to
2a6b732
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62745 +/- ##
==========================================
- Coverage 91.55% 89.69% -1.86%
==========================================
Files 355 706 +351
Lines 149381 218127 +68746
Branches 23364 41737 +18373
==========================================
+ Hits 136765 195653 +58888
- Misses 12354 14404 +2050
- Partials 262 8070 +7808
🚀 New features to boost your workflow:
|
mertcanaltin
approved these changes
Apr 15, 2026
Member
mertcanaltin
left a comment
mertcanaltin
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the edits!
legendecas
reviewed
Apr 15, 2026
| @@ -16,7 +16,7 @@ script to debug. | |||
| ```console | |||
| $ node inspect myscript.js | |||
| < Debugger listening on ws://127.0.0.1:9229/621111f9-ffcb-4e82-b718-48a145fa5db8 | |||
| < For help, see: https://nodejs.org/en/docs/inspector | |||
| < For help, see: https://nodejs.org/api/inspector.html | |||
Member
There was a problem hiding this comment.
The page is actually moved to https://nodejs.org/learn/getting-started/debugging.
Suggested change
| < For help, see: https://nodejs.org/api/inspector.html | |
| < For help, see: https://nodejs.org/learn/getting-started/debugging |
legendecas
requested changes
Apr 15, 2026
| @@ -28,7 +28,7 @@ function check(url, cb) { | |||
| }); | |||
|
|
|||
| res.on('end', common.mustCall(() => { | |||
| assert.match(result, />Debugging Node\.js</); | |||
| assert.match(result, /<title>Inspector \| Node\.js/); | |||
Member
There was a problem hiding this comment.
The page https://nodejs.org/learn/getting-started/debugging still match this matcher.
semimikoh
force-pushed
the
fix/inspector-dead-help-link
branch
from
2a6b732 to
39d8662
Compare
semimikoh
force-pushed
the
fix/inspector-dead-help-link
branch
from
39d8662 to
403ae9c
Compare
legendecas
approved these changes
Apr 15, 2026
Member
|
would you mind fixing the linter errors? |
lpinca
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspector help message pointed to https://nodejs.org/en/docs/inspector
which returns a 404. Updated to https://nodejs.org/api/inspector.html.
Fixes: #62743