Repository navigation
fix(parser): report nesting and template errors consistently - #132
Merged
Merged
Conversation
guybedford
marked this pull request as ready for review
October 10, 2026 04:36
guybedford
approved these changes
Oct 10, 2026
Unexpected closing braces and unterminated nesting return success in the Wasm parser because errors are discarded or never recorded. Unterminated templates in the JavaScript parser call an undefined helper and produce a ReferenceError. Signed-off-by: Ruben Bridgewater <ruben.bridgewater@datadoghq.com>
guybedford
force-pushed
the
BridgeAR/2026-10-05-cjs-wasm-errors
branch
from
October 10, 2026 04:41
1ffef36 to
80012fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unexpected closing braces and unterminated nesting return success in the Wasm parser because errors are discarded or never recorded. Unterminated templates in the JavaScript parser call an undefined helper and produce a ReferenceError.