Repository navigation
Conversation
guybedford
reviewed
Oct 10, 2026
guybedford
left a comment
guybedford
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this, the implementation is consistent between the JS and C sources and I verified the committed Wasm matches a fresh build. The framing of keeping the default patterns frozen while allowing opt-in configuration for new patterns works for me.
One thing to fix before landing: this carries over a pre-existing && / || bug at the reexport site and then codifies it in the tests. See inline comments.
Minifiers can replace `enumerable: true` with `enumerable: !0`, which prevents detection of otherwise supported exports and star reexports. `allowMinifiedEnumerable` enables this spelling for each parse call and preserves the default detection patterns. Refs: #64
Identifiers such as tfoo and xrue produce false star reexports. The enumerable check accepts either the leading t or the remaining rue.
BridgeAR
force-pushed
the
BridgeAR/2026-10-05-minified-enumerable
branch
from
October 11, 2026 09:34
5454a47 to
8891efd
Compare
BridgeAR
marked this pull request as ready for review
October 11, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minifiers can replace
enumerable: truewithenumerable: !0, which prevents detection of otherwise supported exports and star reexports.allowMinifiedEnumerableenables this spelling for each parse call and preserves the default detection patterns.Refs: #64